Author Topic: More Building Requirements  (Read 1703 times)

0 Members and 1 Guest are viewing this topic.

Offline Tom Sawyer

  • Modders
  • Architect
  • *****
  • Posts: 706
Re: More Building Requirements
« Reply #15 on: April 12, 2017, 12:50:15 PM »
Oh, I wrote to him yesterday evening @RedKetchup and did not came to the forum again. Now he will definitely add us to his spam...^^ Lets see.

What copies of the ToolTipToolbar.rsc... have you made? As far as I know the game can only use the originals. And when it crashes in your game? On mouseover (ToolTipToolbar) or click (CreateBar). Or maybe they are just not compiled because not called in mod resource file?

I did not try something new on it but adding more build items does not work @Necora. The game ignores it. Probably this is to be fixed in the core game. To handle more build items by the BuildRequirementUI.

Online RedKetchup

  • Champion
  • Banished Expert
  • *****
  • Posts: 6809
Re: More Building Requirements
« Reply #16 on: April 12, 2017, 12:55:33 PM »
i ve made a copy of these 3 in my dialog and didnt renamed it. i ve let it as a replacement with same name.
in fact , as last try in game ... it is probably when the tooltip should have appeared (after 1 full second) that it crashed, i didnt clicked on it yet. (mouseover)
> > > Support Mods Creation developments with Paypal Donations < < <
Click here to PayPal Donate.

Online RedKetchup

  • Champion
  • Banished Expert
  • *****
  • Posts: 6809
Re: More Building Requirements
« Reply #17 on: April 12, 2017, 01:02:57 PM »
yeah right, i added the tooltiptoolbar reference in the root resource file and it shows the resources with ?? ?.
i ll add the others.
> > > Support Mods Creation developments with Paypal Donations < < <
Click here to PayPal Donate.

Online RedKetchup

  • Champion
  • Banished Expert
  • *****
  • Posts: 6809
Re: More Building Requirements
« Reply #18 on: April 12, 2017, 01:09:25 PM »
it effectively works :) it is just the BuildRequirementUI that is messing.
> > > Support Mods Creation developments with Paypal Donations < < <
Click here to PayPal Donate.

Offline embx61

  • Modders
  • Architect
  • *****
  • Posts: 935
  • You are always on my mind, Forever in my heart
Re: More Building Requirements
« Reply #19 on: April 12, 2017, 01:10:11 PM »
So I am not the only one :)

I am in the same boat as RedKetchup. Even hovering over the building Icon in the Toolbar freezes the game and I have to use Task Manager to shut Banished down.

I can see it is a Access Violation Error and that tells me the game looks for something in memory what is not there.
My beloved Kathy
As you were you will always be
Treasured forever in my memory

Offline embx61

  • Modders
  • Architect
  • *****
  • Posts: 935
  • You are always on my mind, Forever in my heart
Re: More Building Requirements
« Reply #20 on: April 12, 2017, 01:17:00 PM »
Ah, I have to add the files to the XXXresources.rsc files in the root I just read.

Let's get a go at it again.
My beloved Kathy
As you were you will always be
Treasured forever in my memory

Online RedKetchup

  • Champion
  • Banished Expert
  • *****
  • Posts: 6809
Re: More Building Requirements
« Reply #21 on: April 12, 2017, 01:45:46 PM »
Ah, I have to add the files to the XXXresources.rsc files in the root I just read.

Let's get a go at it again.

hehe

on my side i am checking to see if all the other code we can see can cause the error....
i added the build3-4 everywhere... and enable the UI .... but still crashing.
> > > Support Mods Creation developments with Paypal Donations < < <
Click here to PayPal Donate.

Offline embx61

  • Modders
  • Architect
  • *****
  • Posts: 935
  • You are always on my mind, Forever in my heart
Re: More Building Requirements
« Reply #22 on: April 12, 2017, 02:10:07 PM »
Okay get it work just as you guys. The compiler kept complaining about not finding the Build6.rsc file but if I clicked ignore it put the files in the package.
What on earth is up with that is beyond me but it works.

Only one reference is needed for that file, correct? In the Template file of the building.

I see three x x x at the bottom of the tooltip and that is where normally the little icons for the build materials need to go with the text how many of each.


My beloved Kathy
As you were you will always be
Treasured forever in my memory

Online RedKetchup

  • Champion
  • Banished Expert
  • *****
  • Posts: 6809
Re: More Building Requirements
« Reply #23 on: April 12, 2017, 02:19:19 PM »
did you put your build6.rsc in your dialog folder of your mod ?

yeah there is 3 x

if you add a build3 and a build4 and at bottom, a labelbuild 3 and 4 .... you will get 5x
but doesnt make us go further lol
> > > Support Mods Creation developments with Paypal Donations < < <
Click here to PayPal Donate.

Offline embx61

  • Modders
  • Architect
  • *****
  • Posts: 935
  • You are always on my mind, Forever in my heart
Re: More Building Requirements
« Reply #24 on: April 12, 2017, 02:55:28 PM »
Without enabling the Build Requirements UI but added two build items to the ToolTipToolBar.rsc I see now x x x x x instead of x x x.

I guess that enabling the UI will crash. Yeps, it crashes with Access Violation Error :(

I fear that the Build Requirements UI is eiter a hardcoded list or array.
If so , nothing can be done by us. Luke has to expand the array/list up to 6.

Part of the Crash Dump File
Memory addresses and some assembly code for those who are interested. LOL
So it is a INVALID POINTER ERROR, so my fear that it is a hardcode array/list seem to be true.

If Luke made a array or list to store 3 items in the Build Req UI and we add some to it will result in pointing to a pointer in memory what is not existing.
Code: [Select]
FAULTING_IP:
Runtime_x64+4298a
00007ffe`439b298a 493900          cmp     qword ptr [r8],rax

EXCEPTION_RECORD:  ffffffffffffffff -- (.exr 0xffffffffffffffff)
ExceptionAddress: 00007ffe439b298a (Runtime_x64+0x000000000004298a)
   ExceptionCode: c0000005 (Access violation)  [color=red]<========  Object not in memory[/color]
  ExceptionFlags: 00000000
NumberParameters: 2
   Parameter[0]: 0000000000000000
   Parameter[1]: 0000100000000106
Attempt to read from address 0000100000000106

DEFAULT_BUCKET_ID:  INVALID_POINTER_READ

PROCESS_NAME:  Application-x64.exe

ERROR_CODE: (NTSTATUS) 0xc0000005 - The instruction at "0x%08lx" referenced memory at "0x%08lx". The memory could not be "%s". [color=red]// Read[/color]

EXCEPTION_CODE: (NTSTATUS) 0xc0000005 - The instruction at "0x%08lx" referenced memory at "0x%08lx". The memory could not be "%s". [color=red]// Read[/color]

EXCEPTION_PARAMETER1:  0000000000000000

EXCEPTION_PARAMETER2:  0000100000000106

READ_ADDRESS:  0000100000000106

FOLLOWUP_IP:
Runtime_x64+4298a
00007ffe`439b298a 493900          cmp     qword ptr [r8],rax

FAULTING_THREAD:  00000000000016e0

PRIMARY_PROBLEM_CLASS:  INVALID_POINTER_READ   [color=red]<=========================
[/color]
BUGCHECK_STR:  APPLICATION_FAULT_INVALID_POINTER_READ [color=red]<======================
[/color]
LAST_CONTROL_TRANSFER:  from 00007ff67b38efc1 to 00007ffe439b298a

STACK_TEXT: 
000000f2`37ebe418 00007ff6`7b38efc1 : 000000f2`39cdd890 000000f2`3bcafae0 000000f2`37ebe499 000000f2`3d8fa6a8 : Runtime_x64+0x4298a
000000f2`37ebe420 000000f2`39cdd890 : 000000f2`3bcafae0 000000f2`37ebe499 000000f2`3d8fa6a8 000000f2`3bcafa00 : Application_x64+0x5efc1
000000f2`37ebe428 000000f2`3bcafae0 : 000000f2`37ebe499 000000f2`3d8fa6a8 000000f2`3bcafa00 000000f2`00000000 : 0xf2`39cdd890
000000f2`37ebe430 000000f2`37ebe499 : 000000f2`3d8fa6a8 000000f2`3bcafa00 000000f2`00000000 000000f2`3bfc7fe8 : 0xf2`3bcafae0
000000f2`37ebe438 000000f2`3d8fa6a8 : 000000f2`3bcafa00 000000f2`00000000 000000f2`3bfc7fe8 000000f2`3d4622f0 : 0xf2`37ebe499
000000f2`37ebe440 000000f2`3bcafa00 : 000000f2`00000000 000000f2`3bfc7fe8 000000f2`3d4622f0 000000f2`3d462208 : 0xf2`3d8fa6a8
000000f2`37ebe448 000000f2`00000000 : 000000f2`3bfc7fe8 000000f2`3d4622f0 000000f2`3d462208 00000000`00000030 : 0xf2`3bcafa00
000000f2`37ebe450 000000f2`3bfc7fe8 : 000000f2`3d4622f0 000000f2`3d462208 00000000`00000030 000000f2`3bcafae8 : 0xf2`00000000
000000f2`37ebe458 000000f2`3d4622f0 : 000000f2`3d462208 00000000`00000030 000000f2`3bcafae8 00007ffe`43a3d33b : 0xf2`3bfc7fe8
000000f2`37ebe460 000000f2`3d462208 : 00000000`00000030 000000f2`3bcafae8 00007ffe`43a3d33b 000000f2`3a9e57d8 : 0xf2`3d4622f0
000000f2`37ebe468 00000000`00000030 : 000000f2`3bcafae8 00007ffe`43a3d33b 000000f2`3a9e57d8 00007ffe`000001ae : 0xf2`3d462208
000000f2`37ebe470 000000f2`3bcafae8 : 00007ffe`43a3d33b 000000f2`3a9e57d8 00007ffe`000001ae 00000000`00000000 : 0x30
000000f2`37ebe478 00007ffe`43a3d33b : 000000f2`3a9e57d8 00007ffe`000001ae 00000000`00000000 ffffffff`fffffffe : 0xf2`3bcafae8
000000f2`37ebe480 000000f2`3a9e57d8 : 00007ffe`000001ae 00000000`00000000 ffffffff`fffffffe 000000f2`3a9e57d8 : Runtime_x64+0xcd33b
000000f2`37ebe488 00007ffe`000001ae : 00000000`00000000 ffffffff`fffffffe 000000f2`3a9e57d8 00007ffe`000001ae : 0xf2`3a9e57d8
000000f2`37ebe490 00000000`00000000 : ffffffff`fffffffe 000000f2`3a9e57d8 00007ffe`000001ae 000000f2`3d8fa6a8 : 0x7ffe`000001ae


STACK_COMMAND:  ~0s; .ecxr ; kb

SYMBOL_STACK_INDEX:  0

SYMBOL_NAME:  Runtime_x64+4298a

FOLLOWUP_NAME:  MachineOwner

MODULE_NAME: Runtime_x64

IMAGE_NAME:  Runtime-x64.dll

DEBUG_FLR_IMAGE_TIMESTAMP:  58d05a57

FAILURE_BUCKET_ID:  INVALID_POINTER_READ_c0000005_Runtime-x64.dll!Unknown

BUCKET_ID:  X64_APPLICATION_FAULT_INVALID_POINTER_READ_Runtime_x64+4298a
« Last Edit: April 12, 2017, 03:01:00 PM by embx61 »
My beloved Kathy
As you were you will always be
Treasured forever in my memory

Online RedKetchup

  • Champion
  • Banished Expert
  • *****
  • Posts: 6809
Re: More Building Requirements
« Reply #25 on: April 12, 2017, 03:20:14 PM »
yeah :S there is something in the UI code that make it crash like something has been array at 3 max (0,1,2) and try to read position 3 and 4 and it crash cause it not has been defined.


it is in the BuildRequirementUI code because the game can handle the fact it has 5 resource and the building progress window handle it.
it is surely something very little and very stupid inside that UI code ><

maybe
if we would see it, maybe we could add these build3-4 or whatever is missing... but since we cannot edit it ... only Luke can fix that.
« Last Edit: April 12, 2017, 03:24:09 PM by RedKetchup »
> > > Support Mods Creation developments with Paypal Donations < < <
Click here to PayPal Donate.

Offline embx61

  • Modders
  • Architect
  • *****
  • Posts: 935
  • You are always on my mind, Forever in my heart
Re: More Building Requirements
« Reply #26 on: April 12, 2017, 03:31:15 PM »
I did a complete search in the complete resource folder of the Mod Kit for Building Requirement UI and only the 3 references in the three files came up.

So it is a hidden Object.

O well, I am not wasting more time on it as I am sure it will bring us nowhere without Luke fixing it.
My beloved Kathy
As you were you will always be
Treasured forever in my memory

Online RedKetchup

  • Champion
  • Banished Expert
  • *****
  • Posts: 6809
Re: More Building Requirements
« Reply #27 on: April 12, 2017, 03:57:00 PM »
yeah me too i closed everything
couldnt find a solution... .sorry ><
> > > Support Mods Creation developments with Paypal Donations < < <
Click here to PayPal Donate.

Online RedKetchup

  • Champion
  • Banished Expert
  • *****
  • Posts: 6809
Re: More Building Requirements
« Reply #28 on: April 20, 2017, 05:05:57 PM »
i sent an email to Luke about it ....
hopefully we will get some news on this :)

i already pasted a copy of this in Gather our forces thread..... but i post a copy here too....




HEY i ve got some news from Luke today !!!!!!!!! about to upgrade the building requirement from 3 to 6 materials :)

here's a quote copy paste from my email ( his answer is coming first in the quote and then after at bottom, a copy from my words sent to him)


Quote
Hi Michel,

I'll look into it - I think it should be a fairly easy fix/addition without changing to much code, but I won't know until I reproduce the crashes.

As far as my next project, I'm still undecided and working on a few different things. Also working on a bunch of lower level code to support new things which takes a bit of time.




On 4/12/2017 2:38 PM, Michel Guénette wrote:
Hello Luke !

I hope you are going very well !
How goes your games developpement ? Have you decided what is your next project ? last time you told me that you have "some designs in the works for new projects going on and depending which is most fun..." any news on this ?

The moddler community here on world of banished, we tried to look at a way to make pass the 3 building resource requirement to 6 resources instead.
we almost making it even if at first look it should have been impossible without crash...

in fact we found that the game is supporting it, more than 3 resources but there is 2 little rsc that make us crash but if we // comment the
BuildRequirementUI in ToolTipToolbar.rsc and CreateBar.rsc we avoid crashes. The ToolTipUpgrade is affected too. And it works.

so do you think this can be fix easily to allow this 100% fully working ?


In hope to get feedback from you, Luke 😊
Regards,

Michel
> > > Support Mods Creation developments with Paypal Donations < < <
Click here to PayPal Donate.

Online QueryEverything

  • Advisor
  • Banished Expert
  • *****
  • Posts: 1024
Re: More Building Requirements
« Reply #29 on: April 20, 2017, 05:18:17 PM »
That is good news :)  Great work on getting a response @RedKetchup and thanks to Luke who sent the response :D
~ QE, I query because I like learning new things. 

Banished pinterest & Banished mod ideas
(Gently) Please: if you download mods please rate them, this helps & encourages the modders. :)