World of Banished

Conversations => General Discussion => Topic started by: Nilla on February 05, 2017, 08:01:50 AM

Title: Crash while saving
Post by: Nilla on February 05, 2017, 08:01:50 AM
I had a crash, that as far as i can remember, I never had before. It occurs while saving the game. The first time, I think it was autosave but it also happens when I try to save manually. It's weird, because it's not a new game. I've played it for several days. No problem to save before. The menu says; "A fatal violation has occurred in Runtime-x64" . Does anyone know what this is?

Edit: this is even weirder. I tried my last unmodded game. I can save it but the menu looks strange. And i can't load the saved game again.
Title: Re: Crash while saving
Post by: Abandoned on February 05, 2017, 09:31:56 AM
@Nilla I had that happen when I was doing my mountain mission map.  I don't remember exactly, but the problem started when I tried remove the nomad well because I was getting nomads at the mission also, too many nomads.  It started when it was auto saving.  The weird one in the menu is the auto save that didn't finish saving.  If I remember correctly I deleted auto save file, went back to previous good save of map, got a good auto save, played a little, left the well alone, then saved and exited if I remember correctly.  I didn't lose my map.  Hope that helps.
Title: Re: Crash while saving
Post by: Nominix on February 05, 2017, 10:48:28 AM
I also have received this error while removing a mini well that attracts nomads. Every game that I removed it in it started bugging and then crashed. It could also be corrupted files, and given your edit it does sound like you have some corrupted runtime files. Id reinstall the game and see if it continues.
Title: Re: Crash while saving
Post by: Nilla on February 05, 2017, 11:13:33 AM
Thank you! I did actually remove the Nomad well. I will try your tricks @Abandoned and if i doesn't work, reinstall Banished!
Title: Re: Crash while saving
Post by: Nilla on February 05, 2017, 11:43:06 AM
I went back to a save, where I still had the nomad well. It seems like everything works fine. I can save the game manually. It also made an auto save. The saves from my vanilla game still looks odd but I don't need them so I will delete them. Again: thank you @Abandoned and @Nominix. I don't think I would have got the idea, that the Nomad well would cause the trouble myself. Maybe @kid1293, there should be a warning; not to delete the well, when it's once built. (or maybe there is something I haven't seen)
Title: Re: Crash while saving
Post by: kid1293 on February 05, 2017, 03:54:56 PM
Will test Nomad Well and come back.
Title: Re: Crash while saving
Post by: kid1293 on February 06, 2017, 09:31:12 AM

I can't make it crash (lucky me)
Been running and deleting well. For how long?
I can make a note on download page.
I just don't understand why it happens.
Title: Re: Crash while saving
Post by: Agnes53 on February 06, 2017, 11:11:41 AM
Never delete the nomad well! The game will crash. I have experinced this many times. I built the nomad well at the beginning and used it for some time, just to get some extra citizens, I deleted it as soon as I didnĀ“t needed it more, and then the game crashed... Now I never delete it.
Title: Re: Crash while saving
Post by: Abandoned on February 06, 2017, 12:27:10 PM
@kid1293 Did you only have the well that would attract the nomads?  I had the well plus the mission church that attracts nomads on the same map.  As soon as the builder started to dismantle the well, it froze.  It froze when auto saving also.  Then I couldn't save at all.  I thought it was because I had the to nomad attracters. 
Title: Re: Crash while saving
Post by: Nominix on February 06, 2017, 01:46:39 PM
I also had built another building that attracted nomads. But I just dont remember which it was. The lighthouse perhaps...i really dont remember, but in all cases I was using the megamod. Once I built the other building I would remove the nomad well and all manner of bugs would start happening until it crashed and all saves were corrupt after that point. I havent tried using just the nomad well and then removing. IIRC I had always built some other structure to get nomads before removing.
Title: Re: Crash while saving
Post by: kid1293 on February 06, 2017, 02:13:24 PM
So it's maybe in the code.
You can edit and change the nomads but only one?
I can see that there are conflicts if Luke has only one main code for nomads.
So for now I wonder - Did these crashes happen with only one attractor?
I have tested with only the well and deleted and run and nothing happens.
Title: Re: Crash while saving
Post by: Hawk on February 06, 2017, 03:51:29 PM
This may or may not be relevant to this discussion, but I had the mini town hall (from the mini buildings mod) on the map I'm playing. I then built a village hall (from the DSSV Beta V-1.1 mod) and deleted the mini town hall, and so far, after playing a couple of years, I've had no problems.
Both have the Nomads tab.

Here's the list of mods I have installed, in the order they're set up in the mods list within the game (this is when having the spoiler BBCode available would be nice  ;) ).

QuoteCheapTunnels
professionsBox
banishedUImaps
banishedUI
DSSmallVillage Beta V-1.1
DSWagonVendor
DSRoads
DSFences
WoodButcher
TjurkoMill
MiniBuildings
ebbakery
edfix
OldBakeryHouse
OldBlacksmith
OldHunterHut
OldTailorHouse
Tiny
rowhouse
ebfarmstand
EBChurch
EBApothecary
EBFarmhouses
ebbarn
library
college
LessFog
CityRoads
littlehouse
BostonHouse
CountryLittleHouse
MilkFromCows
hydrafastroad25
ForestOutpost
Gridlines
monastery
rootcellar
Radius
endiadika6RealCalendar
sawmill
SpecializedStockpiles
SpecializedTradingPorts
grainsilo
TimeIsMoneyAltVersion1ByDarkbibou
TreeHouse
VillageSchool
warehouse
Mathieuso_Stone_Bridge
Title: Re: Crash while saving
Post by: Nominix on February 06, 2017, 05:44:57 PM
Quote from: kid1293 on February 06, 2017, 02:13:24 PM
So it's maybe in the code.
You can edit and change the nomads but only one?
I can see that there are conflicts if Luke has only one main code for nomads.
So for now I wonder - Did these crashes happen with only one attractor?
I have tested with only the well and deleted and run and nothing happens.

Ill do a couple test runs later tonight and post the results.
Title: Re: Crash while saving
Post by: Nominix on February 06, 2017, 08:23:07 PM
Some Results - All cases ran under megaMod v0.06

1st case -use nomad well without any other attractor - No problems noticed (ran as a seperate game than the other cases, removed and rebuilt the nomad well several times with no issues)

2nd case - built nomad well first, waited till i got first round of nomads, built midevil lighthouse and removed nomad well  - no problems noticed

3rd case - with lighthouse intact, rebuilt nomad well waited on another round of nomads,(Nomad well is where they showed up) accepted them - no problems noticed

4th case - with both nomad well and light house built,built the vanilla town hall (no waiting for more nomads) - all three running no issues

5th case - removed nomad well (left the lighthouse and town hall intact) and waited till next round of nomads (showed up at lighthouse) - as soon as accepted - got immediate bugs - was getting worse as i ran it so I shut it down.

Conclusion - It seems to bug when it has to choose between attractors and one of them is not there. This needs more testing to see if it is indeed only the nomad well or if it is indemic to all attractors and the game simply does not like to have to choose between attractors once it has ??registered them???? or something like that. No clue what the code looks like behind the objects.
Guess it could also be because the nomad well is on a yearly cycle and the others are on longer cycles. As the nomads show up and the well is not there it sends them to another attractor but since its not time for these nomads as the other attractor is on a different cycle it fubars??? Just needs more testing.
Title: Re: Crash while saving
Post by: kid1293 on February 06, 2017, 10:58:48 PM

It all makes sense. I have edited the nomad spawn time and that can be a global
variable in the game.


I think it's best to use only one attractor in a game.
Title: Re: Crash while saving
Post by: Nilla on February 07, 2017, 01:52:38 AM
Sorry to disappoint you guys! I had no other nomad attraction buildings, unless your small city hall (the nice round red one) attracts nomads. I don't think it does, because I played many years and there were never nomads arriving to that building.
Title: Re: Crash while saving
Post by: Abandoned on February 07, 2017, 06:15:21 AM
I only had the problem once.  I like the tiny well because you get a few nomads soon, and don't need town hall and market.  There was no problem with the well and mission nomad church as long as I did try to take away the well.  Nomads came to one or the other sometimes both at the same time.  There is a mod on CC site Many Town Arrival so you can build more than one arrival, and another Town Arrival Nomads that attract nomads with only a trading post (no market needed)  Have not tried either mod yet.
Title: Re: Crash while saving
Post by: purringcat on February 07, 2017, 04:07:40 PM
My game normally never crashes.   But the last two games I've used the tiny well and the game (and PC) crashed even tho I hadn't removed it.    I wasn't at my PC at the time so don't know if there was a message or not.   Didn't connect the crashes to the well until I read this thread.   
Title: Re: Crash while saving
Post by: kid1293 on February 08, 2017, 09:33:26 AM

What do you think?
Shall I remove the well?
I seems as if there are several other ways to attract nomads.
I have to check the code again.
Title: Re: Crash while saving
Post by: kid1293 on February 08, 2017, 10:03:06 AM
Ican not make it crash. Have tested again. Does it take long time?
The only thing I can think of is that I squeezed the numbers too tight.
I wanted them every year.
Maybe the game has no time to 'reset' before next batch is on the way.

Here is a version of Tiny with the old town hall numbers for nomads.
I don't remember releasing the well alone.
Nothing else is changed.
If you want you can test. If this solves the problem I will update download.
Tiny with old numbers - to test with (https://www.dropbox.com/s/relbtj2y6l5cs1u/Tiny_NomadOldNumbers.zip?dl=0)
Title: Re: Crash while saving
Post by: Nominix on February 08, 2017, 10:49:23 AM
Just to add a few more results

I have not been able to crash the game or get any noticeable bugs by just using the well. I have ran it until year 47 with no issues, repeatedly removing the well and adding it back in. For me its only when I start introducing other attractors and removing the well that I get bugs and crashes.
Title: Re: Crash while saving
Post by: kid1293 on February 08, 2017, 11:46:04 AM
As I said I have changed the numbers quite a bit.
Can it be that Luke has only one set of variables for handling the nomads?
If one attractor tells one ting and the other says another value -
when removing the well maybe the numbers remains as some global variables.
Just rambling, but it is sad that this happened.

Do anyone have problems with my mission church? I edited the values.

Does load order play a roll?
Title: Re: Crash while saving
Post by: Nominix on February 08, 2017, 01:04:00 PM
I havent tried yet with your adjusted numbers and getting ready to head to the airport and will be out of town for a few days. So if it hasnt been resolved by the time I return Ill run a few more tests if you need. GL with it.



Title: Re: Crash while saving
Post by: RedKetchup on February 13, 2017, 10:30:08 PM
talking about nomads....

a crash fix has been added in last patch..

QuoteChanges for Banished build 170212

- Added Custom0..9 resource flags and resource limits. Modified UI that uses these accordingly to be able to use them.
- Fixed a bug cause by towm hall deletion while nomads are in route

dunno if can help
Title: Re: Crash while saving
Post by: QueryEverything on February 13, 2017, 11:53:24 PM
I found that my crash when saving was due to a funky Autosave file.
I closed the game, deleted the Autosave (from your saves folder) and restarted.
Once the game was running smoothly I then Exited fully, then restarted again, then reloaded the last good save of my map.
Resaved that, to the current date & time.
Closed Banished and rebooted.

I reboot after each process so I know it's working correctly :D
Title: Re: Crash while saving
Post by: QueryEverything on February 13, 2017, 11:55:55 PM
@kid1293 I haven't had any crashes related to your mod, or your nomad well, I was getting them every December and they would boost each time due to the %% of the villagers already ingame. 

I do have odd CTDs if I touch a UI box in the wrong spot, my field of the UI is very different too, but that's for another thread.

Read my previous post for possible crash issues and how I resolved mine, if it wasn't for the incorrect UI access.
Title: Re: Crash while saving
Post by: kid1293 on February 14, 2017, 12:19:45 AM
Quote from: RedKetchup on February 13, 2017, 10:30:08 PM
talking about nomads....

a crash fix has been added in last patch..

QuoteChanges for Banished build 170212

- Added Custom0..9 resource flags and resource limits. Modified UI that uses these accordingly to be able to use them.
- Fixed a bug cause by towm hall deletion while nomads are in route

dunno if can help

Exactly that!